chore: increase grpc max call send & receive msg size #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3947610556
💛 - Coveralls |
internal/server/server.go
Outdated
| config.grpcAddr(), | ||
| grpc.WithTransportCredentials(insecure.NewCredentials()), | ||
| grpc.WithDefaultCallOptions( | ||
| grpc.MaxCallRecvMsgSize(GRPCMaxClientSendSize), |
There was a problem hiding this comment.
Do we need to increase RecvMsg as well? All of our insert APIs do not seem to need it.
wdyt?
There was a problem hiding this comment.
Not sure about this.
Increased the RecvMsg as well, as asset payload can be huge - but haven't faced this scenario yet.
internal/server/server.go
Outdated
| @@ -30,6 +30,10 @@ import ( | |||
| "google.golang.org/protobuf/encoding/protojson" | |||
| ) | |||
|
|
|||
| const ( | |||
| GRPCMaxClientSendSize = 32 << 20 | |||
There was a problem hiding this comment.
should we make it configurable as well ? wdyt?
There was a problem hiding this comment.
Yes. I think we should be able to configure it also if needed.
There was a problem hiding this comment.
made both values to be configurable
* add support for user configurability of max call recv and send size in grpc config
bsushmith
force-pushed
the
incr-grpc-max-msg-size
branch
from
79369e1 to
e278504
Compare
sudo-suhas
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32MBfrom default4MB.