Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve metrics #149

Merged
merged 1 commit into from
Jun 13, 2022
Merged

improve metrics #149

merged 1 commit into from
Jun 13, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Jun 13, 2022

No description provided.

@mabdh mabdh linked an issue Jun 13, 2022 that may be closed by this pull request
Improve business metrics sent from compass #141
Closed
@mabdh mabdh force-pushed the improve-metrics branch from 3a6f1e2 to 6b7a15d Compare June 13, 2022 03:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2485811561

  • 37 of 82 (45.12%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 79.9%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/elasticsearch/es.go 0 2 0.0%
core/asset/errors.go 0 3 0.0%
internal/server/v1beta1/option.go 0 4 0.0%
internal/server/v1beta1/server.go 2 7 28.57%
core/user/service.go 20 26 76.92%
internal/store/elasticsearch/discovery_repository.go 0 7 0.0%
internal/store/elasticsearch/discovery_search_repository.go 1 9 11.11%
internal/server/v1beta1/asset.go 8 18 44.44%
Totals Coverage Status
Change from base Build 2474586663: -0.4%
Covered Lines: 4484
Relevant Lines: 5612
💛 - Coveralls

@mabdh mabdh marked this pull request as ready for review June 13, 2022 03:23
@mabdh mabdh requested a review from StewartJingga June 13, 2022 03:23
StewartJingga
StewartJingga approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabdh mabdh merged commit 0ab27e9 into main Jun 13, 2022
@mabdh mabdh deleted the improve-metrics branch June 13, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve business metrics sent from compass
3 participants
@mabdh @coveralls @StewartJingga