Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: project structure #131

Merged
merged 13 commits into from
May 23, 2022
Merged

refactor: project structure #131

merged 13 commits into from
May 23, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented May 19, 2022

following project structure standard applied to #entropy

@mabdh mabdh linked an issue May 19, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 19, 2022

Pull Request Test Coverage Report for Build 2368610846

  • 1483 of 1823 (81.35%) changed or added relevant lines in 30 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 81.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/metrics/statsd_monitor.go 7 8 87.5%
core/user/context.go 9 11 81.82%
internal/server/v1beta1/type.go 18 20 90.0%
pkg/grpc_interceptor/user.go 18 20 90.0%
internal/server/health/health.go 0 3 0.0%
internal/server/v1beta1/comment.go 83 88 94.32%
internal/server/v1beta1/search.go 13 18 72.22%
internal/server/v1beta1/server.go 30 36 83.33%
core/discussion/comment.go 0 8 0.0%
internal/server/v1beta1/lineage.go 32 42 76.19%
Totals Coverage Status
Change from base Build 2356199783: -0.3%
Covered Lines: 4530
Relevant Lines: 5590

💛 - Coveralls

@mabdh mabdh force-pushed the refactor-structure branch from e9b8247 to aab80ca Compare May 19, 2022 06:55
@mabdh mabdh force-pushed the refactor-structure branch from ce1d46c to c08efcb Compare May 19, 2022 08:17
@mabdh mabdh force-pushed the refactor-structure branch from c08efcb to 2fe801b Compare May 19, 2022 08:19
@mabdh mabdh requested a review from StewartJingga May 19, 2022 08:31
@mabdh mabdh marked this pull request as ready for review May 19, 2022 08:31
@mabdh mabdh requested a review from ravisuhag May 19, 2022 08:31
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabdh mabdh merged commit 2c63565 into main May 23, 2022
@mabdh mabdh deleted the refactor-structure branch May 23, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update project structure to comply with odpf standard
3 participants