Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tags): replace tags identifier from record urn and type to asset id #122

Merged
merged 8 commits into from
May 12, 2022
Merged

feat(tags): replace tags identifier from record urn and type to asset id #122

merged 8 commits into from
May 12, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented May 11, 2022 •
edited
Loading

  • replace tags identifier from record urn and type to asset id
  • update docs

@mabdh mabdh requested a review from StewartJingga May 11, 2022 00:28
@mabdh mabdh self-assigned this May 11, 2022
@mabdh mabdh linked an issue May 11, 2022 that may be closed by this pull request
Tag template to use Asset ID instead of Record Type and Record URN #114
Closed
@coveralls
Copy link

coveralls commented May 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2311157071

  • 103 of 115 (89.57%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 80.921%
Changes Missing Coverage Covered Lines Changed/Added Lines %
store/postgres/star_repository.go 0 1 0.0%
tag/service.go 11 12 91.67%
api/v1beta1/tag.go 36 38 94.74%
tag/errors.go 0 3 0.0%
store/postgres/tag_repository.go 52 57 91.23%
Totals Coverage Status
Change from base Build 2297846712: -0.08%
Covered Lines: 4780
Relevant Lines: 5907
💛 - Coveralls

StewartJingga
StewartJingga approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabdh mabdh requested a review from StewartJingga May 12, 2022 04:16
@StewartJingga StewartJingga merged commit b761ace into main May 12, 2022
@StewartJingga StewartJingga deleted the tag-template-assetid branch May 12, 2022 04:20
scortier pushed a commit that referenced this pull request May 15, 2022
@mabdh @scortier
feat(tags): replace tags identifier from record urn and type to asset…
ae6e6ea 
… id (#122)

* feat(tags): replace record urn and type in tags to asset id

* chore: update readme

* chore: update docs

* chore: update docs

* chore: update docs and makefile

* fix(tags): fix inconsistent behaviour

* fix(tags): add template not found error check in update tag handler

* chore: fix broken tests in tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees

@mabdh mabdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag template to use Asset ID instead of Record Type and Record URN
3 participants
@mabdh @coveralls @StewartJingga