Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disregarding size while fetching list of assets #117

Merged
merged 2 commits into from
Apr 26, 2022
Merged

feat: allow disregarding size while fetching list of assets #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6706d1d
feat: remove default assets size while fetching list of assets
scortier Apr 25, 2022
5624b4c
refactor: update size operator
scortier Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions store/postgres/asset_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ type AssetRepository struct {

// GetAll retrieves list of assets with filters
func (r *AssetRepository) GetAll(ctx context.Context, flt asset.Filter) ([]asset.Asset, error) {
builder := r.getAssetSQL().Offset(uint64(flt.Offset))
size := flt.Size
if size == 0 {
size = r.defaultGetMaxSize
}

builder := r.getAssetSQL().Limit(uint64(size)).Offset(uint64(flt.Offset))
if size > 0 {
builder = r.getAssetSQL().Limit(uint64(size)).Offset(uint64(flt.Offset))
}
builder = r.BuildFilterQuery(builder, flt)
builder = r.buildOrderQuery(builder, flt)
query, args, err := r.buildSQL(builder)
Expand Down
12 changes: 8 additions & 4 deletions store/postgres/asset_repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,17 +208,20 @@ func (r *AssetRepositoryTestSuite) TestBuildFilterQuery() {
func (r *AssetRepositoryTestSuite) TestGetAll() {
assets := r.insertRecord()

r.Run("should return all assets limited by default size", func() {
r.Run("should return all assets without filtering based on size", func() {
expectedSize := 8

results, err := r.repository.GetAll(r.ctx, asset.Filter{})
r.Require().NoError(err)
r.Require().Len(results, defaultGetMaxSize)
for i := 0; i < defaultGetMaxSize; i++ {
r.Require().Len(results, expectedSize)
for i := 0; i < expectedSize; i++ {
r.assertAsset(&assets[i], &results[i])
}
})

r.Run("should override default size using GetConfig.Size", func() {
size := 6

results, err := r.repository.GetAll(r.ctx, asset.Filter{
Size: size,
})
Expand All @@ -231,11 +234,12 @@ func (r *AssetRepositoryTestSuite) TestGetAll() {

r.Run("should fetch assets by offset defined in GetConfig.Offset", func() {
offset := 2

results, err := r.repository.GetAll(r.ctx, asset.Filter{
Offset: offset,
})
r.Require().NoError(err)
for i := offset; i > defaultGetMaxSize+offset; i++ {
for i := offset; i > len(results)+offset; i++ {
r.assertAsset(&assets[i], &results[i-offset])
}
})
Expand Down