Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grpc): add get assets query params filtering to grpc #109

Merged
merged 4 commits into from
Apr 14, 2022
Merged

feat(grpc): add get assets query params filtering to grpc #109

merged 4 commits into from
Apr 14, 2022

Conversation

scortier
Copy link
Member

@scortier scortier commented Apr 8, 2022

No description provided.

@scortier scortier marked this pull request as draft April 8, 2022 09:24
@mabdh mabdh linked an issue Apr 12, 2022 that may be closed by this pull request
feat(grpc): add get assets query params filtering to grpc #105
Closed
@mabdh mabdh added the enhancement New feature or request label Apr 13, 2022
@mabdh mabdh marked this pull request as ready for review April 13, 2022 09:59
@mabdh mabdh requested a review from StewartJingga April 13, 2022 10:00
StewartJingga
StewartJingga approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabdh mabdh merged commit cccc0f8 into main Apr 14, 2022
@mabdh mabdh deleted the grpc-asset branch April 14, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

@mabdh mabdh

@scortier scortier

@GrayFlash GrayFlash

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(grpc): add get assets query params filtering to grpc
4 participants
@scortier @StewartJingga @mabdh @GrayFlash