Skip to content

Commit

Permalink
feat(grpc): add user and tag templates (#104)
Browse files Browse the repository at this point in the history
  • Loading branch information
mabdh authored Apr 4, 2022
1 parent a88b6fe commit 145df3c
Show file tree
Hide file tree
Showing 26 changed files with 17,749 additions and 2,701 deletions.
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
NAME="github.com/odpf/columbus"
VERSION=$(shell git describe --always --tags 2>/dev/null)
COVERFILE="/tmp/columbus.coverprofile"
PROTON_COMMIT := "c3146a25d9f321bc721d94dbdf3aec8483a3cb03"
PROTON_COMMIT := "4c76e086f7877efc8897ffac74dd45cf75646a78"

.PHONY: all build test clean install proto

Expand Down Expand Up @@ -31,7 +31,6 @@ proto: ## Generate the protobuf files
@buf generate https://github.com/odpf/proton/archive/${PROTON_COMMIT}.zip#strip_components=1 --template buf.gen.yaml --path odpf/compass
@echo " > protobuf compilation finished"


install: ## install required dependencies
@echo "> installing dependencies"
go mod tidy
Expand Down
4 changes: 2 additions & 2 deletions api/httpapi/v1beta1.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func setupV1Beta1Router(router *mux.Router, handlers *Handler) {
// Deprecated: Use setupV1Beta1AssetRoutes instead
setupV1Beta1TypeRoutes("/types", router, handlers.Type, handlers.Record)

setupUserRoutes("/user", router, handlers.User)
setupMeRoutes("/me", router, handlers.User)

setupUsersRoutes("/users", router, handlers.User)

Expand Down Expand Up @@ -108,7 +108,7 @@ func setupV1Beta1TagRoutes(baseURL string, router *mux.Router, th *handlers.TagH
router.Methods(http.MethodDelete).Path(templateURL + "/{template_urn}").HandlerFunc(tth.Delete)
}

func setupUserRoutes(baseURL string, router *mux.Router, ush *handlers.UserHandler) {
func setupMeRoutes(baseURL string, router *mux.Router, ush *handlers.UserHandler) {

router.Path(baseURL + "/starred").
Methods(http.MethodGet).
Expand Down
Loading

0 comments on commit 145df3c

Please sign in to comment.