remove #define RGFWDEF and make the #undefs only happen for their OS (RGFW) #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should hopefully be the last |
|
@ColleagueRiley Nice! Thank you very much for the improvement! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on RGFW support, before I found out I could use RGFW with Raylib without compiling RGFW on it's own I needed to add this line
#define RGFWDEF.This line makes it so the RGFW functions are not inline'd. This could cause potential performance issues for RGFW. I also made it so the
#defsand#undefsrequired to get RGFW with raylib only happen if they're needed for that OS. This is a very minor change but it prevents any unforeseen issues.