Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event recording enhancements #2975

Closed

Conversation

MatthewOwens
Copy link
Contributor

Implements the feature request described in #2948. Added the following functions:

RLAPI void BeginEventRecording(bool displayText);
RLAPI void StopEventRecording(const char *fileName);
RLAPI void PlayEventRecording(const char *fileName, bool displayText);

This change also modifies the behavior of when PlayAutomationEvents is called. It will now play out a recorded event file from when PlayAutomationEvents is called, rather than only playing the file if CORE.Time.frameCounter < eventCount.

@raysan5
Copy link
Owner

raysan5 commented Mar 20, 2023

@MatthewOwens Thanks for the improvement! I need some time to review this API carefully, to align it with raylib.

src/raylib.h Show resolved Hide resolved
src/raylib.h Show resolved Hide resolved
@MatthewOwens
Copy link
Contributor Author

Cheers for the review, I agree that a compilation flag approach would probably be better. I wasn't sure if you'd be open to an additional flag, but I'll switch to that approach and update the function names to better align with raylib's style.

Any concerns around the functionality changes regarding playing events?

@raysan5
Copy link
Owner

raysan5 commented Oct 26, 2023

@MatthewOwens I know it's been a while since this PR but API has been finally redesigned on commit: 99dac54

@raysan5 raysan5 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants