[improve][broker] Improve the extensibility of the TopicBundleAssignm…

…entStrategy interface class (apache#23773)
rayluoluo · Jan 13, 2025 · 3d57043 · 3d57043
1 parent 6a2ebad
commit 3d57043
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 11 deletions.
diff --git a/...r/src/main/java/org/apache/pulsar/common/naming/ConsistentHashingTopicBundleAssigner.java b/...r/src/main/java/org/apache/pulsar/common/naming/ConsistentHashingTopicBundleAssigner.java
@@ -22,7 +22,6 @@
 import java.nio.charset.StandardCharsets;
 import java.util.Optional;
 import org.apache.pulsar.broker.PulsarService;
-import org.apache.pulsar.broker.ServiceConfiguration;
 import org.apache.pulsar.broker.namespace.NamespaceService;
 
 public class ConsistentHashingTopicBundleAssigner implements TopicBundleAssignmentStrategy {

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java b/pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java
@@ -29,7 +29,6 @@
 import com.google.common.collect.Range;
 import com.google.common.hash.HashFunction;
 import java.io.IOException;
-import java.nio.charset.StandardCharsets;
 import java.time.Duration;
 import java.util.Collections;
 import java.util.HashMap;

diff --git a/...r-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategy.java b/...r-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategy.java
@@ -23,7 +23,7 @@
 import org.apache.pulsar.broker.PulsarService;
 
 public interface TopicBundleAssignmentStrategy {
-    NamespaceBundle findBundle(TopicName topicName,  NamespaceBundles namespaceBundles);
+    NamespaceBundle findBundle(TopicName topicName, NamespaceBundles namespaceBundles);
 
     default long calculateBundleHashCode(TopicName topicName) {
         return Hashing.crc32().hashString(topicName.toString(), StandardCharsets.UTF_8).padToLong();

diff --git a/...oker/src/test/java/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategyTest.java b/...oker/src/test/java/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategyTest.java
@@ -23,16 +23,11 @@
 import static org.mockito.Mockito.when;
 import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertTrue;
-
 import com.google.common.base.Charsets;
 import com.google.common.collect.BoundType;
 import com.google.common.collect.Range;
-
 import com.google.common.hash.Hashing;
 import java.lang.reflect.Field;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
-import java.nio.charset.StandardCharsets;
 import java.util.HashSet;
 import java.util.Optional;
 import java.util.Set;
@@ -44,10 +39,7 @@
 import org.apache.pulsar.common.policies.data.LocalPolicies;
 import org.apache.pulsar.common.policies.data.PoliciesUtil;
 import org.apache.pulsar.metadata.api.extended.MetadataStoreExtended;
-import org.mockito.Mockito;
-import org.mockito.internal.util.MockUtil;
 import org.testng.Assert;
-import org.testng.annotations.BeforeClass;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;