Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error-checking for a couple of corruption issues #8059

Merged
merged 2 commits into from
Jun 7, 2020

Conversation

mehrdadn
Copy link
Contributor

@mehrdadn mehrdadn commented Apr 16, 2020

Why are these changes needed?

  • Handles Redis disconnection gracefully in monitor.py

  • Adds error-checking to catch memory corruptions on Windows (and possibly other platforms).

Related issue number

#631

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mehrdadn mehrdadn closed this Apr 16, 2020
@mehrdadn mehrdadn deleted the revert branch April 21, 2020 21:19
@ray-project ray-project deleted a comment from AmplabJenkins Jun 4, 2020
@mehrdadn mehrdadn restored the revert branch June 4, 2020 19:19
@mehrdadn mehrdadn reopened this Jun 4, 2020
@mehrdadn mehrdadn changed the title Revert broken PR Error-checking for a couple of corruption issues Jun 4, 2020
@ray-project ray-project deleted a comment from AmplabJenkins Jun 4, 2020
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26751/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26754/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26796/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26794/
Test PASSed.

@sven1977 sven1977 merged commit f68183d into ray-project:master Jun 7, 2020
@mehrdadn mehrdadn deleted the revert branch June 7, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants