-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove unused flatbuffer messages #51034
Merged
edoakes
merged 14 commits into
ray-project:master
from
edoakes:eoakes/remove-unused-messages
Mar 3, 2025
Merged
[core] Remove unused flatbuffer messages #51034
edoakes
merged 14 commits into
ray-project:master
from
edoakes:eoakes/remove-unused-messages
Mar 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#50740) The serve microbenchmark has been sporadically failing due to memory corruption issues (see the linked issue). One of the tracebacks captured pointed to the fact that the `deleted_generator_ids_` map was being accessed concurrently by multiple threads. Fixed by adding a mutex. Verified that it at least dramatically reduces the frequency of the crashes. I've also renamed a few fields for clarity. ray-project#50802 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
jjyao
approved these changes
Mar 3, 2025
Michaelhess17
pushed a commit
to Michaelhess17/ray
that referenced
this pull request
Mar 3, 2025
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.