-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train V2] Hide the private functions of train context to avoid abuse #50874
Open
hongpeng-guo
wants to merge
19
commits into
ray-project:master
Choose a base branch
from
hongpeng-guo:hpguo/privatize_train_context
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Train V2] Hide the private functions of train context to avoid abuse #50874
hongpeng-guo
wants to merge
19
commits into
ray-project:master
from
hongpeng-guo:hpguo/privatize_train_context
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
justinvyu
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Updates: comments are handled. PTAL @justinvyu |
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
justinvyu
reviewed
Feb 27, 2025
Co-authored-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Co-authored-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Co-authored-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Co-authored-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Take one more look ? @justinvyu |
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
…ngpeng-guo/ray into hpguo/privatize_train_context
justinvyu
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some remaining nits. should be good after this!
Co-authored-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
…ngpeng-guo/ray into hpguo/privatize_train_context
justinvyu
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In V2, users should not be able to access the private methods / attributes.
For example,
ray.train.get_context()._save_checkpoint
should not be accessible. Only the public APIs (get_world_rank
, etc.) should be available from code completion.Added a
TrainContext
class in theray/train/v2/api/context.py
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.