Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data/preprocessors] feat: allow transformer to be executed in append mode #50856

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[data/preprocessors] feat: allow transformer to be executed in append mode #50856

merged 1 commit into from
Feb 26, 2025

Conversation

martinbomio
Copy link
Contributor

@martinbomio martinbomio commented Feb 24, 2025 •
edited
Loading

Why are these changes needed?

This is part of #48133. Continuing the approach taken in #49426, make transformer work in append mode

Related issue number

#49426

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@martinbomio martinbomio requested a review from a team as a code owner February 24, 2025 16:50
@martinbomio martinbomio changed the title [data/preprocessors] feat: aloow transfoormer to be executed in append mode [data/preprocessors] feat: aloow transformer to be executed in append mode Feb 24, 2025
richardliaw
richardliaw reviewed Feb 24, 2025
View reviewed changes
python/ray/data/tests/preprocessors/test_transformer.py Outdated

# Test append mode
# First test that providing wrong number of output columns raises error
with pytest.raises(ValueError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check error message pls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@martinbomio
feat: aloow transfoormer to be executed in append mode
881891f 
Signed-off-by: Martin Bomio <martinbomio@spotify.com>
@martinbomio martinbomio force-pushed the martinbomio/transformer-append-mode branch from 8ddfc05 to 881891f Compare February 24, 2025 19:33
@martinbomio martinbomio changed the title [data/preprocessors] feat: aloow transformer to be executed in append mode [data/preprocessors] feat: allow transformer to be executed in append mode Feb 25, 2025
@jcotant1 jcotant1 added the data Ray Data-related issues label Feb 25, 2025
@richardliaw richardliaw added the go add ONLY when ready to merge, run all tests label Feb 26, 2025
@richardliaw richardliaw merged commit 858d4be into ray-project:master Feb 26, 2025
6 checks passed
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 28, 2025
@martinbomio @kevin85421
[data/preprocessors] feat: allow transformer to be executed in append…
6240dba 
… mode (ray-project#50856)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make transformer work in
append mode

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
Signed-off-by: kaihsun <kaihsun@anyscale.com>
Michaelhess17 pushed a commit to Michaelhess17/ray that referenced this pull request Mar 3, 2025
@martinbomio @Michaelhess17
[data/preprocessors] feat: allow transformer to be executed in append…
c3391b0 
… mode (ray-project#50856)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make transformer work in
append mode

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@martinbomio @xsuler
[data/preprocessors] feat: allow transformer to be executed in append…
d319979 
… mode (ray-project#50856)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make transformer work in
append mode

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees
No one assigned
Labels
data Ray Data-related issues go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbomio @richardliaw @jcotant1