Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data/preprocessors] feat: allow hasher to run on append mode #50632

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[data/preprocessors] feat: allow hasher to run on append mode #50632

merged 1 commit into from
Feb 26, 2025

Conversation

martinbomio
Copy link
Contributor

@martinbomio martinbomio commented Feb 15, 2025 •
edited
Loading

Why are these changes needed?

This is part of #48133. Continuing the approach taken in #49426, make all the hashers work in append mode

Related issue number

#49426

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

martinbomio
martinbomio commented Feb 15, 2025
View reviewed changes
python/ray/data/preprocessors/hasher.py Outdated
self,
columns: List[str],
num_features: int,
output_columns: Optional[List[str]] = None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardliaw wondering what your thoughts are on these changes. The FeatureHasher already create new columns, but it drops the original columns from the result dataset.
How can we enable/disable the dropping of the columns?

In these changes I opted for having the output_columns, which should name the transformed columns (instead of naming them hash_{i}) and if the output columns are provided, it will also make it so that the hasher doesn't drop the original columns.

Not super happy with this, there are a few other options we could take, like having an append, that controls whether to drop the original or not, but that won't allow us to name the output columns differently (as we do on other preprocessors)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think it makes sense to only have a single output_column here, and disable the dropping of columns altogether?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardliaw not sure I follow. Right now the hasher preprocessor outputs num_features new columns. Are you saying that you want to change it so it always returns a single column with a a list of num_features elements?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this would save us from headache in situations with wider tables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in ec6f311

@martinbomio martinbomio force-pushed the martinbomio/hasher-append-mode branch from 23ff71d to ec6f311 Compare February 21, 2025 19:00
@martinbomio martinbomio marked this pull request as ready for review February 21, 2025 19:00
@martinbomio martinbomio requested a review from a team as a code owner February 21, 2025 19:00
@martinbomio martinbomio changed the title feat: allow hasher to run on append mode [data/preprocessors] feat: allow hasher to run on append mode Feb 21, 2025
@martinbomio martinbomio force-pushed the martinbomio/hasher-append-mode branch 2 times, most recently from 97c6a27 to 76b1834 Compare February 21, 2025 20:06
@martinbomio martinbomio mentioned this pull request Feb 24, 2025
Merged
8 tasks
@martinbomio martinbomio force-pushed the martinbomio/hasher-append-mode branch from 879239d to 63f94ab Compare February 24, 2025 03:03
@richardliaw richardliaw enabled auto-merge (squash) February 24, 2025 18:52
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Feb 24, 2025
auto-merge was automatically disabled February 24, 2025 21:04

Head branch was pushed to by a user without write access

@martinbomio martinbomio force-pushed the martinbomio/hasher-append-mode branch from 63f94ab to f0fa89c Compare February 24, 2025 21:04
richardliaw pushed a commit that referenced this pull request Feb 24, 2025
@martinbomio
[data/preprocessors] feat: allow vectorizers to be executed in append…
fb5aee6 
… mode (#50847)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of #48133.
Continuing the approach taken in
#49426, make all the vectorizers
work in append mode.
Took similar approach to #50632
where the vectorizers also change to output a single column instead of
one column per token or per num_feature

## Related issue number

#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
@martinbomio martinbomio force-pushed the martinbomio/hasher-append-mode branch from f0fa89c to a20798c Compare February 25, 2025 02:50
@martinbomio
feat: allow hasher to run on append mode
89515e0 
Signed-off-by: Martin Bomio <martinbomio@spotify.com>
@martinbomio martinbomio force-pushed the martinbomio/hasher-append-mode branch from a20798c to 89515e0 Compare February 25, 2025 14:05
@richardliaw richardliaw merged commit 8aabebf into ray-project:master Feb 26, 2025
5 checks passed
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 28, 2025
@martinbomio @kevin85421
[data/preprocessors] feat: allow vectorizers to be executed in append…
04dc7b9 
… mode (ray-project#50847)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make all the vectorizers
work in append mode.
Took similar approach to ray-project#50632
where the vectorizers also change to output a single column instead of
one column per token or per num_feature

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
Signed-off-by: kaihsun <kaihsun@anyscale.com>
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 28, 2025
@martinbomio @kevin85421
[data/preprocessors] feat: allow hasher to run on append mode (ray-pr…
40a4bea 
…oject#50632)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make all the hashers work
in append mode

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
Signed-off-by: kaihsun <kaihsun@anyscale.com>
Michaelhess17 pushed a commit to Michaelhess17/ray that referenced this pull request Mar 3, 2025
@martinbomio @Michaelhess17
[data/preprocessors] feat: allow vectorizers to be executed in append…
65ec076 
… mode (ray-project#50847)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make all the vectorizers
work in append mode.
Took similar approach to ray-project#50632
where the vectorizers also change to output a single column instead of
one column per token or per num_feature

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
Michaelhess17 pushed a commit to Michaelhess17/ray that referenced this pull request Mar 3, 2025
@martinbomio @Michaelhess17
[data/preprocessors] feat: allow hasher to run on append mode (ray-pr…
b482532 
…oject#50632)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make all the hashers work
in append mode

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@martinbomio @xsuler
[data/preprocessors] feat: allow vectorizers to be executed in append…
c621791 
… mode (ray-project#50847)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make all the vectorizers
work in append mode.
Took similar approach to ray-project#50632
where the vectorizers also change to output a single column instead of
one column per token or per num_feature

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@martinbomio @xsuler
[data/preprocessors] feat: allow hasher to run on append mode (ray-pr…
119f6ac 
…oject#50632)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This is part of ray-project#48133.
Continuing the approach taken in
ray-project#49426, make all the hashers work
in append mode

## Related issue number

ray-project#49426

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Martin Bomio <martinbomio@spotify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbomio @richardliaw