Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to Binder notebooks in Ray Tune tutorials #50621

Merged
merged 6 commits into from
Feb 15, 2025
Merged

Remove references to Binder notebooks in Ray Tune tutorials #50621

merged 6 commits into from
Feb 15, 2025

Conversation

crypdick
Copy link
Contributor

Why are these changes needed?

  • deletes the binder/ folder
  • deletes all references to launching Binder notebooks
  • unhides some important cells while hiding the output of others
  • clarifies the pip requirements for Tune tutorials
  • adds .conda to .gitignore

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@crypdick
Add .conda to .gitignore
31e90f9 
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@crypdick
Misc cleanup:
bc2bedb 
* deletes the binder/ folder
* deletes all references to launching Binder notebooks
* unhides some important cells while hiding the output of others
* clarifies the pip requirements for Tune tutorials

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@crypdick
delete references to Binder in the docs
12a6366 
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@crypdick
Rm doc/source/rllib/package_ref/env/ line that was accidentally inclu…
9af183e 
…ded in .gitignore

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@crypdick
add back trailing newline in .gitignore
b78f10d 
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
@matthewdeng matthewdeng enabled auto-merge (squash) February 14, 2025 22:53
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Feb 14, 2025
@github-actions github-actions bot disabled auto-merge February 15, 2025 20:29
@pcmoritz pcmoritz enabled auto-merge (squash) February 15, 2025 20:42
@pcmoritz pcmoritz disabled auto-merge February 15, 2025 20:42
@pcmoritz pcmoritz enabled auto-merge (squash) February 15, 2025 20:42
@pcmoritz pcmoritz merged commit 34a2d2c into master Feb 15, 2025
7 checks passed
@pcmoritz pcmoritz deleted the docs/blender branch February 15, 2025 22:54
400Ping pushed a commit to 400Ping/ray that referenced this pull request Feb 20, 2025
@crypdick @400Ping
Remove references to Binder notebooks in Ray Tune tutorials (ray-proj…
2b1305f 
…ect#50621)

## Why are these changes needed?

* deletes the binder/ folder
* deletes all references to launching Binder notebooks
* unhides some important cells while hiding the output of others
* clarifies the pip requirements for Tune tutorials
* adds `.conda` to `.gitignore`

## Related issue number

N/A

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
israbbani pushed a commit that referenced this pull request Feb 25, 2025
@crypdick @israbbani
Remove references to Binder notebooks in Ray Tune tutorials (#50621)
4fe03c7 
## Why are these changes needed?

* deletes the binder/ folder
* deletes all references to launching Binder notebooks
* unhides some important cells while hiding the output of others
* clarifies the pip requirements for Tune tutorials
* adds `.conda` to `.gitignore`

## Related issue number

N/A

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@crypdick @xsuler
Remove references to Binder notebooks in Ray Tune tutorials (ray-proj…
c69c5fc 
…ect#50621)

## Why are these changes needed?

* deletes the binder/ folder
* deletes all references to launching Binder notebooks
* unhides some important cells while hiding the output of others
* clarifies the pip requirements for Tune tutorials
* adds `.conda` to `.gitignore`

## Related issue number

N/A

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@crypdick @xsuler
Remove references to Binder notebooks in Ray Tune tutorials (ray-proj…
774f861 
…ect#50621)

## Why are these changes needed?

* deletes the binder/ folder
* deletes all references to launching Binder notebooks
* unhides some important cells while hiding the output of others
* clarifies the pip requirements for Tune tutorials
* adds `.conda` to `.gitignore`

## Related issue number

N/A

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@hongpeng-guo hongpeng-guo Awaiting requested review from hongpeng-guo hongpeng-guo is a code owner

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crypdick @matthewdeng @pcmoritz