Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-place ArrowBlockAccessor::random_shuffle #50594

Merged
merged 4 commits into from
Feb 15, 2025

Conversation

srinathk10
Copy link
Contributor

Why are these changes needed?

Add in-place ArrowBlockAccessor::random_shuffle
Addresses #42146

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
@srinathk10 srinathk10 requested a review from a team as a code owner February 14, 2025 06:15
@srinathk10 srinathk10 added the go add ONLY when ready to merge, run all tests label Feb 14, 2025
Signed-off-by: srinathk10 <68668616+srinathk10@users.noreply.github.com>
@raulchen raulchen enabled auto-merge (squash) February 14, 2025 18:17
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
@github-actions github-actions bot disabled auto-merge February 14, 2025 22:26
@raulchen raulchen merged commit e18a59a into master Feb 15, 2025
5 checks passed
@raulchen raulchen deleted the srinathk10-random_shuffle branch February 15, 2025 04:35
400Ping pushed a commit to 400Ping/ray that referenced this pull request Feb 20, 2025
## Why are these changes needed?
Add in-place ArrowBlockAccessor::random_shuffle
Addresses ray-project#42146

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: srinathk10 <68668616+srinathk10@users.noreply.github.com>
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
israbbani pushed a commit that referenced this pull request Feb 25, 2025
## Why are these changes needed?
Add in-place ArrowBlockAccessor::random_shuffle
Addresses #42146

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: srinathk10 <68668616+srinathk10@users.noreply.github.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
## Why are these changes needed?
Add in-place ArrowBlockAccessor::random_shuffle
Addresses ray-project#42146

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: srinathk10 <68668616+srinathk10@users.noreply.github.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
## Why are these changes needed?
Add in-place ArrowBlockAccessor::random_shuffle
Addresses ray-project#42146

---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: srinathk10 <68668616+srinathk10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants