-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Fix check failure due to negative available resource #50517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
MengjinYan
reviewed
Feb 13, 2025
dentiny
reviewed
Feb 13, 2025
MengjinYan
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 20, 2025
…ect#50517) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
israbbani
pushed a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
…ect#50517) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
…ect#50517) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The sequence of events that can trigger the check failure:
{"CPU_group_aaa": 2, "CPU_group_0_aaa": 1, "CPU_group_1_aaa": 1}
{"CPU_group_aaa": 1, "CPU_group_0_aaa": 0, "CPU_group_1_aaa": 1}
{"CPU_group_aaa": 2, "CPU_group_0_aaa": 1, "CPU_group_1_aaa": 1}
{"CPU_group_aaa": 1, "CPU_group_0_aaa": 0, "CPU_group_1_aaa": 1}
{"CPU_group_aaa": 0, "CPU_group_0_aaa": -1, "CPU_group_1_aaa": 1}
CPU_group_1_aaa
but notCPU_group_aaa
. The fix is that we allowCPU_group_aaa
to go negative as well to match the indexed PG CPU resources.Related issue number
Closes #50433
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.