Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Redact redis password in log #50409

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[core] Redact redis password in log #50409

merged 4 commits into from
Feb 11, 2025

Conversation

letaoj
Copy link
Contributor

@letaoj letaoj commented Feb 11, 2025 •
edited
Loading

Why are these changes needed?

This change is needed to prevent redis password been logged in the standard logging. This is a secure vulnerability.

Related issue number

Closes #50266

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@letaoj
[core] Redact redis password in log
685b2b9 
Signed-off-by: Letao Jiang <letaoj@gmail.com>
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Feb 11, 2025
letaoj and others added 2 commits February 11, 2025 10:23
@letaoj
Merge branch 'master' into redact-redis-pass
c0ecac0
@pcmoritz
lint
bbbe729 
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
@pcmoritz pcmoritz added the go add ONLY when ready to merge, run all tests label Feb 11, 2025
@pcmoritz
Update server.py
fd7a4be 
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
@pcmoritz
Copy link
Contributor

Thanks for the contribution! I made a small fix and verified it works:

==> ray_client_server.err <==
2025-02-11 14:16:26,814	INFO server.py:900 -- Starting Ray Client server on 127.0.0.1:10001, args Namespace(host='127.0.0.1', port=10001, mode='proxy', address='127.0.0.1:6379', redis_username=None, redis_password='****', runtime_env_agent_address='http://127.0.0.1:60712')

@pcmoritz pcmoritz enabled auto-merge (squash) February 11, 2025 22:18
@letaoj
Copy link
Contributor Author

letaoj commented Feb 11, 2025 •
edited
Loading

@pcmoritz ah, I saw you enabled auto merge. Thanks!

@pcmoritz pcmoritz merged commit 64a2e40 into ray-project:master Feb 11, 2025
6 checks passed
israbbani pushed a commit that referenced this pull request Feb 25, 2025
@letaoj @pcmoritz @israbbani
[core] Redact redis password in log (#50409)
b7c9abd 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
This change is needed to prevent redis password been logged in the
standard logging. This is a secure vulnerability.

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes #1234" -->
Closes #50266

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [x] This PR is not tested :(

---------

Signed-off-by: Letao Jiang <letaoj@gmail.com>
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@letaoj @pcmoritz @xsuler
[core] Redact redis password in log (ray-project#50409)
d62d778 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
This change is needed to prevent redis password been logged in the
standard logging. This is a secure vulnerability.

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes ray-project#1234" -->
Closes ray-project#50266

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [x] This PR is not tested :(

---------

Signed-off-by: Letao Jiang <letaoj@gmail.com>
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@letaoj @pcmoritz @xsuler
[core] Redact redis password in log (ray-project#50409)
ab55b88 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
This change is needed to prevent redis password been logged in the
standard logging. This is a secure vulnerability.

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes ray-project#1234" -->
Closes ray-project#50266

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [x] This PR is not tested :(

---------

Signed-off-by: Letao Jiang <letaoj@gmail.com>
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ray Core] Redis password got logged when starting the client server
3 participants
@letaoj @pcmoritz @jcotant1