Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add a Function to Get Per Node Infeasible Request Resource Shapes in GCS Autoscaling State Manager #50084

Closed
wants to merge 6 commits into from

Conversation

MengjinYan
Copy link
Collaborator

Why are these changes needed?

The PR contains the Part 1 of the changes to early terminate the infeasible tasks when it is detected by autoscaler.

It added GetPerNodeInfeasibleResourceRequests function to obtain the infeasible requests resource shape per node. Added the corresponding tests as well.

Changes for the following PRs:

  • Add an endpoint on raylet to cancel the infeasible tasks by resource shape, leveraging the CancelTasks function in cluster_task_manager
  • Add the corresponding raylet_client side calling logic
  • Add logic in gcs_autoscaler_state_manager to cancel the infeasible tasks leveraging the GetPerNodeInfeasibleResourceRequests function to get the infeasible information and the newly added endpoint to cancel the tasks

Related issue number

Part 1 of #45909

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MengjinYan MengjinYan requested a review from a team as a code owner January 27, 2025 18:10
aslonnie and others added 5 commits January 27, 2025 10:37
those are used in legacy setup. we no longer use those anymore.

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
@MengjinYan MengjinYan requested a review from a team as a code owner January 27, 2025 18:40
@MengjinYan MengjinYan closed this Jan 27, 2025
@aslonnie aslonnie removed the request for review from a team January 27, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants