[serve] Remove extra pickle serialization for gRPCRequest
#49943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
jimmyxie-figma
pushed a commit
to jimmyxie-figma/ray
that referenced
this pull request
Jan 20, 2025
…oject#49943) We were pickling the inner proto message, then again pickling the `gRPCRequest` object. No need to do both. Also cleaned up the `request_object` method signature for clarity. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Jimmy Xie <rxie@figma.com>
jimmyxie-figma
pushed a commit
to jimmyxie-figma/ray
that referenced
this pull request
Jan 20, 2025
…oject#49943) We were pickling the inner proto message, then again pickling the `gRPCRequest` object. No need to do both. Also cleaned up the `request_object` method signature for clarity. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Jimmy Xie <rxie@figma.com>
anson627
pushed a commit
to anson627/ray
that referenced
this pull request
Jan 31, 2025
…oject#49943) We were pickling the inner proto message, then again pickling the `gRPCRequest` object. No need to do both. Also cleaned up the `request_object` method signature for clarity. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Anson Qian <anson627@gmail.com>
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
We were pickling the inner proto message, then again pickling the `gRPCRequest` object. No need to do both. Also cleaned up the `request_object` method signature for clarity. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
anyadontfly
pushed a commit
to anyadontfly/ray
that referenced
this pull request
Feb 13, 2025
…oject#49943) We were pickling the inner proto message, then again pickling the `gRPCRequest` object. No need to do both. Also cleaned up the `request_object` method signature for clarity. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We were pickling the inner proto message, then again pickling the
gRPCRequestobject. No need to do both.Also cleaned up the
request_objectmethod signature for clarity.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.