[WIP][Core][Compiled Graph] Add API to Specify DAG Concurrence Group #48600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As mentioned in #46336, the current implementation runs all aDAGs in a background concurrency group
_ray_system
. Meanwhile, actors run in their own default concurrency group. This discrepancy complicates the DAG's ability to access thread-local states within actors that were initialized before the DAG's execution. For example, consider the following code:which will raise an error:
In this PR, we add a new API for
experimental_compile
that allows user to optionally specify the DAG's concurrency group.concurrence_group
isNone
, we will acquire the actor default executor for execution. This ensures that the DAG runs on the same thread as the actor. The above example should now give the expected result by default.concurrence_group: str
is specified, we will try to find the corresponding executor (ref) from the concurrency groups created when creating the actor. If it's not found, theray::core::ConcurrencyGroupManager
will raise a Check failed error. An example would be:Related issue number
Problem described in #46336.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.