[Docs][KubeRay] Update KubeRay + Kueue guides to use newer versions of Kueue #48564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
requested review from
maxpumperla,
pcmoritz,
kevin85421 and
a team
as code owners
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
andrewsykim
force-pushed
the
kueue-guide-version-update
branch
from
37f8cea to
ff3d7b8
Compare
andrewsykim
commented
Nov 5, 2024
| @@ -37,16 +37,16 @@ Create a GKE cluster with the `enable-autoscaling` option: | |||
| ```bash | |||
| gcloud container clusters create kuberay-gpu-cluster \ | |||
| --num-nodes=1 --min-nodes 0 --max-nodes 1 --enable-autoscaling \ | |||
| --zone=us-west1-b --machine-type e2-standard-4 --cluster-version 1.29 | |||
| --zone=us-east4-c --machine-type e2-standard-4 | |||
There was a problem hiding this comment.
I switched the zone just based on personal experience, this zone has less stockouts for L4 GPUs
kevin85421
approved these changes
Nov 5, 2024
|
I have already informed our doc team to review the PR. |
pcmoritz
approved these changes
Nov 5, 2024
angelinalg
reviewed
Nov 5, 2024
| @@ -55,14 +55,10 @@ gcloud beta container node-pools create gpu-node-pool \ | |||
| --machine-type g2-standard-4 | |||
| ``` | |||
|
|
|||
| This command creates a node pool which initially has zero nodes. Use the `gcloud beta` command because some of the flags have beta status. | |||
| This command creates a node pool which initially has zero nodes. | |||
There was a problem hiding this comment.
missing comma:
This command creates a node pool, which initially has zero nodes.
Closed
angelinalg
added a commit
that referenced
this pull request
Nov 5, 2024
missing comma related to #48564 Had to try again because @can-anyscale suspects a rare ReadTheDocs failure and there's no easy way to kick off a rebuild from the browser. Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
angelinalg
added a commit
that referenced
this pull request
Nov 6, 2024
missing comma related to #48564 Had to try again because @can-anyscale suspects a rare ReadTheDocs failure and there's no easy way to kick off a rebuild from the browser. Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…f Kueue (ray-project#48564) ## Why are these changes needed? Update KubeRay + Kueue guides to use newer versions of Kueue ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [X] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
missing comma related to ray-project#48564 Had to try again because @can-anyscale suspects a rare ReadTheDocs failure and there's no easy way to kick off a rebuild from the browser. Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…f Kueue (ray-project#48564) ## Why are these changes needed? Update KubeRay + Kueue guides to use newer versions of Kueue ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [X] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: Andrew Sy Kim <andrewsy@google.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
missing comma related to ray-project#48564 Had to try again because @can-anyscale suspects a rare ReadTheDocs failure and there's no easy way to kick off a rebuild from the browser. Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Update KubeRay + Kueue guides to use newer versions of Kueue
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.