Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove unused GCS RPCs #40808

Merged
merged 8 commits into from
Nov 1, 2023
Merged

[core] Remove unused GCS RPCs #40808

merged 8 commits into from
Nov 1, 2023

Conversation

vitsai
Copy link
Contributor

@vitsai vitsai commented Oct 30, 2023

Why are these changes needed?

Clean up some tech debt as part of test refactoring for #40488

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

vitsai added 4 commits October 26, 2023 22:19
@vitsai
remove dead code
8360f68 
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@vitsai
wip
c157614 
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@vitsai
fix client test
783bae3 
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@vitsai
remove mock
aa7e724 
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
vitsai added 3 commits October 30, 2023 21:15
@vitsai
fix accessor test
d80ebf6 
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@vitsai
remove virtual
f6e5934 
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@vitsai
Merge branch 'master' into experimental-remove
a01b2d1
@vitsai vitsai marked this pull request as ready for review October 31, 2023 18:49
@vitsai vitsai requested review from a team, ericl, pcmoritz and raulchen as code owners October 31, 2023 18:49
jjyao
jjyao reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

rickyyx
rickyyx approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Were this unsed for a long time?

Do you know what's the previous usage?

@vitsai
Copy link
Contributor Author

vitsai commented Oct 31, 2023

These seem to be legacy RPCs from before we moved to Ray Syncer

@vitsai
comments
afb970c 
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@jjyao jjyao merged commit c85e15a into ray-project:master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

@rickyyx rickyyx rickyyx approved these changes

@ericl ericl Awaiting requested review from ericl

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

Assignees

@jjyao jjyao

@rickyyx rickyyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitsai @jjyao @rickyyx