[Serve] Skip test_max_replicas_per_node on Windows #40030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
sihanwang41
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Hi @jjyao, i am still feeling using fixture is cleaner than using finally, you don't need to deal with try-catch-finally by yourself. All serve tests uses pytest.fixture, e.g. test_standalone.py
sihanwang41
approved these changes
Oct 3, 2023
Zandew
pushed a commit
to Zandew/ray
that referenced
this pull request
Oct 10, 2023
ray-project#36926 makes the test flaky by launching extra worker nodes than needed. Seems it's more flaky on Windows so disabling the test on Windows for now until the underlying issue is fixed. Also make sure we clean up everything even when tests fail. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
ray-project#36926 makes the test flaky by launching extra worker nodes than needed. Seems it's more flaky on Windows so disabling the test on Windows for now until the underlying issue is fixed. Also make sure we clean up everything even when tests fail. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#36926 makes the test flaky by launching extra worker nodes than needed. Seems it's more flaky on Windows so disabling the test on Windows for now until the underlying issue is fixed.
Also make sure we clean up everything even when tests fail.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.