Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add a rich logging configuration #33600

Closed

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Mar 22, 2023

Why are these changes needed?

This PR adds a rich logging configuration for Ray, improving driver log message visibility, and adding valuable context for troubleshooting.

This PR is blocked until #32741 is merged.

Related issue number

Partially addresses #30005.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you tell me which file I need to look at?

@peytondmurray peytondmurray force-pushed the rich-logging-config branch 3 times, most recently from 07f2478 to ffd4798 Compare April 5, 2023 23:04
Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray changed the title [WIP] Add a rich logging configuration [Core] Add a rich logging configuration Apr 5, 2023
@peytondmurray
Copy link
Contributor Author

I've rebased onto master, so the only files left are the ones I've changed. Thanks for taking a look!

@peytondmurray peytondmurray marked this pull request as ready for review April 6, 2023 05:48
@rkooo567
Copy link
Contributor

rkooo567 commented Apr 6, 2023

Nice that it is one file change :)! I will run this locally tomorrow!

@stale
Copy link

stale bot commented May 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 8, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants