Make sure all-to-all operator return num outputs so progress bar can work #31825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jianoaix <iamjianxiao@gmail.com>
jianoaix
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
c21
as code owners
c21
reviewed
Jan 21, 2023
| @@ -226,6 +227,14 @@ def _sleep(block_iter: Iterable[Block]) -> Iterable[Block]: | |||
| wait_for_condition(lambda: (ray.available_resources().get("GPU", 0) == 1.0)) | |||
|
|
|||
|
|
|||
| def test_prograss_bar(): | |||
There was a problem hiding this comment.
why this unit test is testing progress bar? didn't see any assertion around progress bar, so asking.
There was a problem hiding this comment.
It's a bit indirect because the progress bar is a local variable that's involved in execution. Make it test num outputs for operators.
ericl
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To enable the new bulk execution backend: #30903
Based on the most recent test (https://buildkite.com/ray-project/oss-ci-build-pr/builds/9947#_), this should be last issue to fix it!
(note the failure of Dataset tests is not real as all tests passing, some issue with bazel test)
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.