Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] maintain scrollbar position on redirects, fixes #31789 #31804

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[docs] maintain scrollbar position on redirects, fixes #31789 #31804

merged 1 commit into from
Jan 25, 2023

Conversation

maxpumperla
Copy link
Contributor

Signed-off-by: Max Pumperla max.pumperla@googlemail.com

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@maxpumperla
[docs] maintain scrollbar posiion on redirects, fixes #31789
2fe2361 
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla maxpumperla requested a review from a team as a code owner January 20, 2023 09:43
pcmoritz
pcmoritz approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's very nice!

@richardliaw richardliaw merged commit 7018e1e into master Jan 25, 2023
@richardliaw richardliaw deleted the mp_nav_scrollbar branch January 25, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxpumperla @pcmoritz @richardliaw