Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] De-flake tune_scalability_network_overhead [smoketest] #31580

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

bveeramani
Copy link
Member

Signed-off-by: Balaji Veeramani balaji@anyscale.com

Why are these changes needed?

tl;dr: Timeout is too short. This PR increases the timeout.

tune_scalability_network_overhead [smoketest] failed twice recently.

In each case, the test "was successful":

The result network overhead test took 386.87 seconds, which is below the budget of 1000.00 seconds. Test successful.
--
  |  
  | PASSED: RESULT NETWORK OVERHEAD ::: 386.87 <= 1000.00 ---

But CI failed:

Traceback (most recent call last):
--
  | File "/tmp/release-h7VxvWLfwr/release/ray_release/glue.py", line 302, in run_release_test
  | command, env=command_env, timeout=command_timeout
  | File "/tmp/release-h7VxvWLfwr/release/ray_release/command_runner/sdk_runner.py", line 130, in run_command
  | f"Cluster command timed out after {timeout} seconds."
  | ray_release.exception.CommandTimeout: Cluster command timed out after 400 seconds.
  |  

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani requested review from cadedaniel and removed request for cadedaniel January 11, 2023 00:36
@krfricke krfricke merged commit 7d5399f into ray-project:master Jan 11, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
**tl;dr**: Timeout is too short. This PR increases the timeout.

`tune_scalability_network_overhead [smoketest]` failed twice recently.

In each case, the test "was successful", But CI failed

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants