Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc][aws][autoscaler] Update AWS cluster cfg yaml to use default AMI. #31567

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

gjoliver
Copy link
Member

@gjoliver gjoliver commented Jan 10, 2023

Signed-off-by: Jun Gong jungong@anyscale.com

Why are these changes needed?

Update the example yamls to reflect updated default AMIs that work with newer nvidia drivers/gpus.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [*] Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jun Gong <jungong@anyscale.com>
Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep hardcoding the ami in example-full.yaml at least so it remains full? For reference the AMI should be ami-0387d929287ab193e

On a related note, perhaps we could also add a comment here https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/_private/aws/config.py#L40 stating to update the examples if we update the dictionary (you can assign me a TODO to make it a unit test)

Signed-off-by: Jun Gong <jungong@anyscale.com>
@gjoliver
Copy link
Member Author

Can we keep hardcoding the ami in example-full.yaml at least so it remains full? For reference the AMI should be ami-0387d929287ab193e

On a related note, perhaps we could also add a comment here https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/_private/aws/config.py#L40 stating to update the examples if we update the dictionary (you can assign me a TODO to make it a unit test)

oh, that's where these images are defined. 👌
done. ptal.

Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wuisawesome
Copy link
Contributor

Final thing, can you update the PR description and stuff?

@wuisawesome wuisawesome changed the title [Doc] Update AWS cluster cfg yaml to use default AMI. [Doc][aws][autoscaler] Update AWS cluster cfg yaml to use default AMI. Jan 10, 2023
@wuisawesome
Copy link
Contributor

nvm actually i can do it

@gjoliver
Copy link
Member Author

thanks man. this is a doc only PR.
these RLlib and Tune test failures are unrelated.
merging.

@gjoliver gjoliver merged commit c27859f into ray-project:master Jan 10, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@gjoliver gjoliver deleted the ami branch February 17, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants