-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc][aws][autoscaler] Update AWS cluster cfg yaml to use default AMI. #31567
Conversation
Signed-off-by: Jun Gong <jungong@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep hardcoding the ami in example-full.yaml
at least so it remains full? For reference the AMI should be ami-0387d929287ab193e
On a related note, perhaps we could also add a comment here https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/_private/aws/config.py#L40 stating to update the examples if we update the dictionary (you can assign me a TODO to make it a unit test)
Signed-off-by: Jun Gong <jungong@anyscale.com>
oh, that's where these images are defined. 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Final thing, can you update the PR description and stuff? |
nvm actually i can do it |
thanks man. this is a doc only PR. |
#31567) Signed-off-by: Jun Gong <jungong@anyscale.com>
Signed-off-by: Jun Gong jungong@anyscale.com
Why are these changes needed?
Update the example yamls to reflect updated default AMIs that work with newer nvidia drivers/gpus.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.