[RLlib] RLTrainer stand-alone unittests #31552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
2. multi-gpus tests pass now Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
kouroshHakha
requested review from
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
krfricke
as code owners
kouroshHakha
commented
Jan 10, 2023
| @@ -23,6 +25,7 @@ def setUp(cls) -> None: | |||
| def tearDown(cls) -> None: | |||
| ray.shutdown() | |||
|
|
|||
| @pytest.mark.skip | |||
There was a problem hiding this comment.
We'll reactivate this test as a trainer_runner test once we iterate through the interface of trainer_runner and algorithm to solidify its design.
2. Added the unittest to the BUILD file Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
2. Added the unittest to the BUILD file Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
…o rltrainer-unittests
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
gjoliver
approved these changes
Jan 10, 2023
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
avnishn
reviewed
Jan 10, 2023
|
|
||
| with tf.GradientTape() as tape: | ||
| params = trainer.module[DEFAULT_POLICY_ID].trainable_variables | ||
| loss = {"total_loss": sum([tf.reduce_sum(param) for param in params])} |
There was a problem hiding this comment.
nice property that you've used here.
avnishn
reviewed
Jan 10, 2023
| @@ -1146,7 +1146,7 @@ def get_cartpole_dataset_reader(batch_size: int = 1) -> "DatasetReader": | |||
| get_dataset_and_shards, | |||
| ) | |||
|
|
|||
| path = "tests/data/cartpole/large.json" | |||
| path = "rllib/tests/data/cartpole/large.json" | |||
There was a problem hiding this comment.
I think you need to remove this prepend
There was a problem hiding this comment.
yep yep. just pushed a patch.
avnishn
approved these changes
Jan 10, 2023
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
* moved rl_optimizer logic into rl_trainer * added in_test to RLTrainer to allow doing test-specific stuff * multi-gpus tests pass now Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements the stand-alone unittests for RLTrainer. Right now it only includes tf stuff, later we will extend it to torch.
This follows up this #31511
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.