Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci][perf][core] ray.wait & ray.get ownership check improvement #31539

Merged
merged 2 commits into from
Jan 9, 2023
Merged

[ci][perf][core] ray.wait & ray.get ownership check improvement #31539

merged 2 commits into from
Jan 9, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jan 9, 2023

Why are these changes needed?

There was regression seen due to O(n) checking of object ownership at ray.get and ray.wait (see more in #31284)

This PR:

  1. adds a more efficient checking that doesn't allocate rpc::Address.
  2. adds a microbenchmark that tests ray.wait with 1k reference objects in loop

TODO:

  • add the microbenchmark to core dashboard.

Related issue number

Closes #31284

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

rickyyx added 2 commits January 9, 2023 19:05
@rickyyx
perf test
c2ef2bf 
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx
query impro
a5c4cc1 
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx
Copy link
Contributor Author

rickyyx commented Jan 9, 2023

Perf metrics:

  • With the fix: 7.29 +- 0.02
  • W/o the fix (master) : 4.56 +- 0.01

@rickyyx rickyyx marked this pull request as ready for review January 9, 2023 19:46
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 9, 2023
@ericl ericl merged commit b29890d into ray-project:master Jan 9, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@rickyyx @AmeerHajAli
[ci][perf][core] ray.wait & ray.get ownership check improvement (#31539)
e87bb6c 
There was regression seen due to O(n) checking of object ownership at `ray.get` and `ray.wait` (see more in #31284) 

This PR:
1.  adds a more efficient checking that doesn't allocate `rpc::Address`. 
2. adds a microbenchmark that tests `ray.wait` with 1k reference objects in loop

TODO:
- add the microbenchmark to core dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

@scv119 scv119

@jjyao jjyao

@rkooo567 rkooo567

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core][nightly] many_actors regression
5 participants
@rickyyx @ericl @scv119 @jjyao @rkooo567