Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accelerator type A10G #31534

Merged

Conversation

zoltan-fedor
Copy link
Contributor

This closes #31533

Why are these changes needed?

AWS offers the A10G in the p5. instance type (like p5.xlarge, p5.2xlarge, etc). We use that instance type along with p4dn (Nvidia Tesla T4). I would like to add A10G so code is more uniform.

Related issue number

Closes #31533

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

This closes ray-project#31533

Signed-off-by: Zoltan Fedor <zoltan.1.fedor@gmail.com>
@wuisawesome
Copy link
Contributor

Doc failure doesn't look related. Merging.

Thanks for the contribution @zoltan-fedor

@wuisawesome wuisawesome merged commit 296dd27 into ray-project:master Jan 10, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
AWS offers the [A10G in the p5. instance type](https://aws.amazon.com/ec2/instance-types/g5/) (like p5.xlarge, p5.2xlarge, etc). We use that instance type along with p4dn (Nvidia Tesla T4). I would like to add A10G so code is more uniform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Support Nvidia A10G accelerator_type
2 participants