Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Improve metrics aggregation Train user guide #31498

Merged

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jan 6, 2023

Signed-off-by: Antoni Baum antoni.baum@protonmail.com

Why are these changes needed?

Improve the section concerning metrics aggregation from workers in the Train DL User Guide.

Related issue number

Closes #31434

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Yard1 added 2 commits January 6, 2023 19:04
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@richardliaw richardliaw merged commit f491e5c into ray-project:master Jan 9, 2023
@Yard1 Yard1 deleted the aggregate_distributed_metrics_doc branch January 9, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Train] Update documentation to show how to use torchmetrics for metric aggregation
2 participants