[ci][nightly] no ray.wait in a loop for many_actors test #31412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickyyx <rickyx@anyscale.com>
|
https://buildkite.com/ray-project/release-tests-pr/builds/24584#01857963-babc-470c-9268-c0ebfe74e57c |
cadedaniel
approved these changes
Jan 4, 2023
scv119
approved these changes
Jan 5, 2023
|
Hmm just for 5000 object refs, the regression seems to bad? Maybe we should fix the root case as well? Do we have an open issue? |
|
Yeah - let's use the original issue for tracking the |
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
Signed-off-by: rickyyx <rickyx@anyscale.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…31412 Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rickyyx rickyx@anyscale.com
Why are these changes needed?
many_actorsregressed sinceray.waitregresses, which could be non-related to whatmany_actorsis testing.See more in #31284 for detailed root-cause.
Related issue number
Mitigates #31284
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.