Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Remove gitpod #31355

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Dec 29, 2022

Signed-off-by: rickyyx rickyx@anyscale.com

Why are these changes needed?

Reverting changes from #15420 so that we no longer need to update the Dockerfile here with python upgrade and dependency changes.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
Copy link
Contributor

@scv119 scv119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the side effect of removing it?

@rickyyx
Copy link
Contributor Author

rickyyx commented Jan 5, 2023

what's the side effect of removing it?

Well - I guess it's only if people use gitpod.

@scv119 scv119 merged commit 0eed4f9 into ray-project:master Jan 5, 2023
@rickyyx rickyyx deleted the remote-gitpod-docker branch January 5, 2023 21:22
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
Reverting changes from #15420 so that we no longer need to update the Dockerfile here with python upgrade and dependency changes.
Signed-off-by: rickyyx <rickyx@anyscale.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
Reverting changes from ray-project#15420 so that we no longer need to update the Dockerfile here with python upgrade and dependency changes.
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants