Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][telemetry] ray.get timeout=0 telemetry tracking #31159

Merged
merged 12 commits into from
Jan 5, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Dec 16, 2022

Why are these changes needed?

This is to gauge the usage of ray.get(timeout=0) which will have a different behaviour in future ray versions, as per #28465

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
.
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx changed the title Ray get timeout 0 tele [core][telemetry] ray.get timeout=0 telemetry tracking Dec 28, 2022
@rickyyx rickyyx marked this pull request as ready for review December 28, 2022 01:46
@rickyyx
Copy link
Contributor Author

rickyyx commented Jan 4, 2023

cc @scv119 for merging.

@scv119 scv119 merged commit 2a6be70 into ray-project:master Jan 5, 2023
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
This is to gauge the usage of ray.get(timeout=0) which will have a different behaviour in future ray versions, as per #28465
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
…1159)

This is to gauge the usage of ray.get(timeout=0) which will have a different behaviour in future ray versions, as per ray-project#28465

Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants