Revert "Revert "[ci/release] Move all release tests to use Ray jobs instead of SDK commands"" #30969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 8, 2022 14:22
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
simon-mo
approved these changes
Dec 9, 2022
|
Are we confident this will work 100%? Why don't we migrate gradually? Like moving the wholes suites to job based executor first |
rkooo567
requested changes
Dec 14, 2022
|
Yeah this is moving gradually (we default to sdk_command). It's currently not working for some tests, e.g. #31123 has to be resolved first |
|
Just to be clear, the relevant line (which was different in the original PR) is this: |
rkooo567
approved these changes
Dec 15, 2022
added 3 commits
January 5, 2023 10:05
Signed-off-by: Kai Fricke <kai@anyscale.com> # Conflicts: # release/ray_release/glue.py # release/release_tests.yaml
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
|
A recent run of release tests passed (all failures are also failing on master): https://buildkite.com/ray-project/release-tests-pr/builds/24762 The default is to stay with sdk runner, so I'll merge this PR and we can the migrate the other tests piece by piece. |
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
…nstead of SDK commands"" (#30969) This will move _some_ more release tests to use Ray jobs instead of the anyscale SDK command runner. The default remains to use the SDK runner. Subsequent tests will be migrated piece by piece. Signed-off-by: Kai Fricke <kai@anyscale.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…nstead of SDK commands"" (ray-project#30969) This will move _some_ more release tests to use Ray jobs instead of the anyscale SDK command runner. The default remains to use the SDK runner. Subsequent tests will be migrated piece by piece. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30956