Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update contribution guide to mention when to use REP #30844

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

zhe-thoughts
Copy link
Collaborator

Signed-off-by: Zhe Zhang zhz@anyscale.com

Why are these changes needed?

This is a small change. Our current contribution guide doesn't mention how to propose features / larger changes. I spotted the issue when processing https://discuss.ray.io/t/using-ray-over-infiniband/5883/9

Related issue number

N/A (directly submitting this PR since change is very small)

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :( (pure doc change)

Signed-off-by: Zhe Zhang <zhz@anyscale.com>
@zhe-thoughts zhe-thoughts added the docs An issue or change related to documentation label Dec 2, 2022
@zhe-thoughts zhe-thoughts requested a review from a team as a code owner December 2, 2022 00:18
@stale
Copy link

stale bot commented Jan 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jan 2, 2023
@zhe-thoughts zhe-thoughts removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jan 4, 2023
@krfricke krfricke merged commit bc20b6d into master Jan 4, 2023
@krfricke krfricke deleted the zhe-thoughts-patch-1 branch January 4, 2023 10:56
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
This is a small change. Our current contribution guide doesn't mention how to propose features / larger changes. I spotted the issue when processing https://discuss.ray.io/t/using-ray-over-infiniband/5883/9

Signed-off-by: Zhe Zhang <zhz@anyscale.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
…ect#30844)

This is a small change. Our current contribution guide doesn't mention how to propose features / larger changes. I spotted the issue when processing https://discuss.ray.io/t/using-ray-over-infiniband/5883/9

Signed-off-by: Zhe Zhang <zhz@anyscale.com>
Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants