Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] SampleBatch: Docstring- and API cleanups; Add support for nested data. #17485

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 1, 2021

SampleBatch: Docstring- and API cleanups; Add support for nested data.

  • adds support for SampleBatches to hold nested data, e.g. a dict of dicts, of tuples of np.ndarrays. All methods have been enhanced to use the dm_tree module when having to loop through the batch. This will allow us later to handle individual "obs" (or other) sub-components in case users want to specify view requirements for only parts of the observation (e.g. obs_space=Dict(img=..., level=...) -> framestack only the img component of the observations via trajectory view API).
  • clean up SampleBatch API further (deprecation warnings, rename zero_pad into right_zero_pad for clarity, etc..).
  • add more SampleBatch test cases.
  • add slicing operator support: e.g. my_slice = batch[4:102].

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 12, 2021
@sven1977 sven1977 merged commit 2bd2ee7 into ray-project:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants