Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove code paths that contains plasma store executable #14950

Merged
merged 9 commits into from
Mar 29, 2021

Conversation

suquark
Copy link
Member

@suquark suquark commented Mar 26, 2021

Why are these changes needed?

Currently, plasma running as thread actually has been enabled by default (because java launches Ray using python scripts). Some critical functions like object spilling are also assuming that plasma store is running as a thread. So the outdated code path is no longer used and it is not functioning correctly.

However, some C++ tests are using plasma store running as a process for testing, this is not good because they are not testing what we are currently using. This PR removes the outdated plasma store executable and migrates those tests. This also reduces the size of our wheel build.

This PR may be required to pass some tests in #14924

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@suquark suquark changed the title [WIP] Remove code paths that contains plasma store executable [WIP] [Core] Remove code paths that contains plasma store executable Mar 26, 2021
@suquark suquark changed the title [WIP] [Core] Remove code paths that contains plasma store executable [Core] Remove code paths that contains plasma store executable Mar 26, 2021
@suquark suquark added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 27, 2021
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!!

@suquark suquark merged commit 87c7955 into ray-project:master Mar 29, 2021
@suquark suquark deleted the remove_plasma_executable branch March 29, 2021 04:22
@mattip mattip mentioned this pull request Sep 12, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants