Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky #48288

Closed
can-anyscale opened this issue Oct 28, 2024 · 60 comments · Fixed by #48433 or #48808
Closed

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky #48288

can-anyscale opened this issue Oct 28, 2024 · 60 comments · Fixed by #48433 or #48808
Assignees
@stephanie-wang @ruisearch42
Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ P1 Issue that should be fixed within a few weeks ray-test-bot Issues managed by OSS test policy stability

Comments

@can-anyscale
Copy link
Collaborator

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d1c2-1479-41d6-bf43-5727365f667f
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d187-63be-42ea-9a3e-4e2ff54b9f96

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy
@can-anyscale can-anyscale added bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases labels Oct 28, 2024
@can-anyscale
Copy link
Collaborator Author

new and flaky test

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6705#0192d3e2-fd18-45b5-a512-a9b4bf2ce350

@can-anyscale can-anyscale changed the title CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky Oct 28, 2024
@can-anyscale can-anyscale reopened this Oct 28, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d1c2-1479-41d6-bf43-5727365f667f
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d187-63be-42ea-9a3e-4e2ff54b9f96

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6705#0192d438-fbe9-469b-8250-a76386293294

@can-anyscale can-anyscale reopened this Oct 28, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6705#0192d3e2-fd1a-44c7-8a2b-f82ff3f69711
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d1c2-1479-41d6-bf43-5727365f667f
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d187-63be-42ea-9a3e-4e2ff54b9f96

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale can-anyscale removed the weekly-release-blocker Issues that will be blocking Ray weekly releases label Oct 28, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6705#0192d3e2-fd1a-44c7-8a2b-f82ff3f69711
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d1c2-1479-41d6-bf43-5727365f667f
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d187-63be-42ea-9a3e-4e2ff54b9f96

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6719#0192d59a-e22c-46b1-b7e4-dd945cfad604

@can-anyscale can-anyscale changed the title CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing Oct 29, 2024
@can-anyscale can-anyscale reopened this Oct 29, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6719#0192d5d9-1dc7-4dc8-8c0c-2d0df3b65377
- https://buildkite.com/ray-project/postmerge/builds/6719#0192d59a-e227-4cc6-a196-acf9f0c8ab41
- https://buildkite.com/ray-project/postmerge/builds/6705#0192d3e2-fd1a-44c7-8a2b-f82ff3f69711
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d1c2-1479-41d6-bf43-5727365f667f
- https://buildkite.com/ray-project/postmerge/builds/6696#0192d187-63be-42ea-9a3e-4e2ff54b9f96

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6721#0192d6ab-d499-4e83-b956-7d7c70e5e524

@can-anyscale can-anyscale changed the title CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky Oct 29, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6981#01933de3-62ae-4b79-890d-30f6ff1fcc33
- https://buildkite.com/ray-project/postmerge/builds/6975#01933283-9f5a-4a0a-8859-12bd80aa4ae5
- https://buildkite.com/ray-project/postmerge/builds/6975#01933283-9f61-4ea5-9d14-06d073a4b0b3
- https://buildkite.com/ray-project/postmerge/builds/6972#019331a4-a76c-4055-ac29-43e38f39e541
- https://buildkite.com/ray-project/postmerge/builds/6965#01932e6d-929d-44e1-ba32-095d2ff9f32e

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6981#01933de3-62ae-4b79-890d-30f6ff1fcc33
- https://buildkite.com/ray-project/postmerge/builds/6975#01933283-9f5a-4a0a-8859-12bd80aa4ae5
- https://buildkite.com/ray-project/postmerge/builds/6975#01933283-9f61-4ea5-9d14-06d073a4b0b3
- https://buildkite.com/ray-project/postmerge/builds/6972#019331a4-a76c-4055-ac29-43e38f39e541

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@jjyao jjyao added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 18, 2024
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6985#019341af-ab36-4334-adf0-886d76717731

@can-anyscale can-anyscale reopened this Nov 19, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6986#019341f4-6b78-4d15-aa0b-75596572bd99
- https://buildkite.com/ray-project/postmerge/builds/6981#01933de3-62ae-4b79-890d-30f6ff1fcc33
- https://buildkite.com/ray-project/postmerge/builds/6975#01933283-9f5a-4a0a-8859-12bd80aa4ae5
- https://buildkite.com/ray-project/postmerge/builds/6975#01933283-9f61-4ea5-9d14-06d073a4b0b3
- https://buildkite.com/ray-project/postmerge/builds/6972#019331a4-a76c-4055-ac29-43e38f39e541

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6990#01934300-8454-4620-bd26-2f12482a56e4

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6992#01934433-3e29-487f-b3c9-26c7bfaf026a

@can-anyscale can-anyscale changed the title CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing Nov 19, 2024
@can-anyscale can-anyscale reopened this Nov 19, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-525d-4110-a4cd-fbc99786a157
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-5261-47c3-a715-bb7543bf040d
- https://buildkite.com/ray-project/postmerge/builds/6995#01934568-b84e-4330-b414-23e8da465728
- https://buildkite.com/ray-project/postmerge/builds/6986#019341f4-6b78-4d15-aa0b-75596572bd99

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale can-anyscale changed the title CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is consistently_failing CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky Nov 19, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-525d-4110-a4cd-fbc99786a157
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-5261-47c3-a715-bb7543bf040d
- https://buildkite.com/ray-project/postmerge/builds/6995#01934568-b84e-4330-b414-23e8da465728
- https://buildkite.com/ray-project/postmerge/builds/6986#019341f4-6b78-4d15-aa0b-75596572bd99

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@stephanie-wang stephanie-wang mentioned this issue Nov 20, 2024
Merged
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7008#01934806-7501-4352-84cf-c1835fbd8d80

@can-anyscale can-anyscale reopened this Nov 20, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/7009#0193482f-50b5-43e9-826b-1bfd1d646657
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-525d-4110-a4cd-fbc99786a157
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-5261-47c3-a715-bb7543bf040d
- https://buildkite.com/ray-project/postmerge/builds/6995#01934568-b84e-4330-b414-23e8da465728

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

1 similar comment
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/7009#0193482f-50b5-43e9-826b-1bfd1d646657
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-525d-4110-a4cd-fbc99786a157
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-5261-47c3-a715-bb7543bf040d
- https://buildkite.com/ray-project/postmerge/builds/6995#01934568-b84e-4330-b414-23e8da465728

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

stephanie-wang added a commit that referenced this issue Nov 20, 2024
@stephanie-wang
[core][compiled graphs] Wait for monitor thread to join before shutti…
eea0057 
…ng down (#48808)

Each compiled graph starts a monitor thread to tear down the DAG upon
detecting an error in one of the workers' task loops. Currently, during
driver shutdown, this thread can live past the lifetime of the C++
CoreWorker. This causes a silent process exit when the thread later
tries to call on the CoreWorker but it has already been destructed. To
prevent this from happening, this fix joins the monitor thread *before*
destructing the CoreWorker.

## Related issue number

Closes #48288.

---------

Signed-off-by: Stephanie Wang <smwang@cs.washington.edu>
@can-anyscale can-anyscale reopened this Nov 20, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/7012#01934a8a-ca35-48b8-a17e-93155a3a04cf
- https://buildkite.com/ray-project/postmerge/builds/7009#0193482f-50b5-43e9-826b-1bfd1d646657
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-525d-4110-a4cd-fbc99786a157
- https://buildkite.com/ray-project/postmerge/builds/7003#01934641-5261-47c3-a715-bb7543bf040d
- https://buildkite.com/ray-project/postmerge/builds/6995#01934568-b84e-4330-b414-23e8da465728

DataCaseName-linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7018#01934b1e-eadf-4208-91fc-08e323b940a0

jecsand838 pushed a commit to jecsand838/ray that referenced this issue Dec 4, 2024
@stephanie-wang @jecsand838
[core][compiled graphs] Wait for monitor thread to join before shutti…
f452004 
…ng down (ray-project#48808)

Each compiled graph starts a monitor thread to tear down the DAG upon
detecting an error in one of the workers' task loops. Currently, during
driver shutdown, this thread can live past the lifetime of the C++
CoreWorker. This causes a silent process exit when the thread later
tries to call on the CoreWorker but it has already been destructed. To
prevent this from happening, this fix joins the monitor thread *before*
destructing the CoreWorker.

## Related issue number

Closes ray-project#48288.

---------

Signed-off-by: Stephanie Wang <smwang@cs.washington.edu>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny pushed a commit to dentiny/ray that referenced this issue Dec 7, 2024
@stephanie-wang @dentiny
[core][compiled graphs] Wait for monitor thread to join before shutti…
ab2f2c7 
…ng down (ray-project#48808)

Each compiled graph starts a monitor thread to tear down the DAG upon
detecting an error in one of the workers' task loops. Currently, during
driver shutdown, this thread can live past the lifetime of the C++
CoreWorker. This causes a silent process exit when the thread later
tries to call on the CoreWorker but it has already been destructed. To
prevent this from happening, this fix joins the monitor thread *before*
destructing the CoreWorker.

## Related issue number

Closes ray-project#48288.

---------

Signed-off-by: Stephanie Wang <smwang@cs.washington.edu>
Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanie-wang stephanie-wang

@ruisearch42 ruisearch42

Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ P1 Issue that should be fixed within a few weeks ray-test-bot Issues managed by OSS test policy stability
Projects
None yet
Milestone
No milestone
4 participants
@jjyao @stephanie-wang @can-anyscale @ruisearch42