Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autoscaler][Logs][minor] Prefix (autoscaler) instead of (scheduler) for autoscaler events #24807

Closed
DmitriGekhtman opened this issue May 14, 2022 · 6 comments · Fixed by #31489
Closed

[Autoscaler][Logs][minor] Prefix (autoscaler) instead of (scheduler) for autoscaler events #24807

DmitriGekhtman opened this issue May 14, 2022 · 6 comments · Fixed by #31489
Labels
bug Something that is supposed to be working; but isn't good-first-issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P2 Important issue, but not time-critical
Milestone
Infra Backlog

Comments

@DmitriGekhtman
Copy link
Contributor

What happened + What you expected to happen

The autoscaler pushes some logs to the Ray driver. The logs are prefixed with (scheduler) which is misleading.
The prefix should be (autoscaler).

Versions / Dependencies

Ray master.

Reproduction script

Submit a Ray task or actor which triggers upscaling to trigger the logs.

Issue Severity

Low: It annoys or frustrates me.
@DmitriGekhtman DmitriGekhtman added bug Something that is supposed to be working; but isn't good-first-issue Great starter issue for someone just starting to contribute to Ray P2 Important issue, but not time-critical triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 14, 2022
@DmitriGekhtman DmitriGekhtman added this to the Infra Backlog milestone May 14, 2022
@truelegion47
Copy link
Contributor

Can you please post some logs as example so I can pinpoint what places it might be coming from in autoscaler ?

@DmitriGekhtman
Copy link
Contributor Author

Thanks -- will do -- this issue could indeed use more context.

@truelegion47
Copy link
Contributor

@DmitriGekhtman Is this still needed ? If yes, could you please add some logs/context here when you get a chance ? I can throw in a fix.

@wuisawesome
Copy link
Contributor

@slu0

@scottsun94 scottsun94 added the observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling label Oct 13, 2022
@scottsun94
Copy link
Contributor

@DmitriGekhtman It seems that we are waiting for more context : )

@DmitriGekhtman
Copy link
Contributor Author

Run any Ray workload workload that triggers autoscaling, such as the one described here: https://docs.ray.io/en/latest/ray-contribute/fake-autoscaler.html (can be run on a laptop).
Messages describing scaling events will be slightly confusingly prefixed with (scheduler) rather than (autoscaler).

@rkooo567 rkooo567 changed the title [Autoscaler][Logs][minor] [Autoscaler][Logs][minor] Prefix (autoscaler) instead of (scheduler) for autoscaler events Oct 30, 2022
@rkooo567 rkooo567 removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Oct 30, 2022
@gvspraveen gvspraveen mentioned this issue Jan 6, 2023
Merged
7 tasks
wuisawesome pushed a commit that referenced this issue Jan 6, 2023
@gvspraveen
[Autoscaler] Prefix (autoscaler) instead of (scheduler) for autoscale…
5c7826f 
…r events (#31489)

Signed-off-by: praveeng <praveeng@anyscale.com>

# Why are these changes needed?

Autoscaler event logs are prefixed with (scheduler) which is misleading. This PR changes the prefix to be (autoscaler)

Tested building ray locally and running an application (see attached logs). Added unit tests.

# Related issue number

Closes #24807
AmeerHajAli pushed a commit that referenced this issue Jan 12, 2023
@gvspraveen @AmeerHajAli
[Autoscaler] Prefix (autoscaler) instead of (scheduler) for autoscale…
0721a10 
…r events (#31489)

Signed-off-by: praveeng <praveeng@anyscale.com>

# Why are these changes needed?

Autoscaler event logs are prefixed with (scheduler) which is misleading. This PR changes the prefix to be (autoscaler)

Tested building ray locally and running an application (see attached logs). Added unit tests.

# Related issue number

Closes #24807
tamohannes pushed a commit to ju2ez/ray that referenced this issue Jan 25, 2023
@gvspraveen @tamohannes
[Autoscaler] Prefix (autoscaler) instead of (scheduler) for autoscale…
8be3fcf 
…r events (ray-project#31489)

Signed-off-by: praveeng <praveeng@anyscale.com>

# Why are these changes needed?

Autoscaler event logs are prefixed with (scheduler) which is misleading. This PR changes the prefix to be (autoscaler)

Tested building ray locally and running an application (see attached logs). Added unit tests.

# Related issue number

Closes ray-project#24807


Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that is supposed to be working; but isn't good-first-issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P2 Important issue, but not time-critical
Projects
None yet
Milestone
Infra Backlog
5 participants
@wuisawesome @scottsun94 @rkooo567 @DmitriGekhtman @truelegion47