Skip to content

Commit

Permalink
Remove UT libraries and clean up remaining UT datastructures (#1230)
Browse files Browse the repository at this point in the history
* Remove UT string include from redis

* Remove UT string include from DB tests

* Modify TaskSpec_print to remove UT string

* Remove UT libraries
  • Loading branch information
pschafhalter authored and pcmoritz committed Nov 19, 2017
1 parent ae4e1dd commit e0360eb
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 2,721 deletions.
2 changes: 0 additions & 2 deletions src/common/state/redis.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ extern "C" {
#include "hiredis/adapters/ae.h"
}

#include "utstring.h"

#include "common.h"
#include "db.h"
#include "db_client_table.h"
Expand Down
8 changes: 4 additions & 4 deletions src/common/task.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
#include <stddef.h>
#include <stdint.h>
#include "common.h"
#include "utstring.h"

#include <string>

#include "format/common_generated.h"

Expand Down Expand Up @@ -360,10 +361,9 @@ ObjectID task_compute_put_id(TaskID task_id, int64_t put_index);
* Print the task as a humanly readable string.
*
* @param spec The task_spec in question.
* @param output The buffer to write the string to.
* @return Void.
* @return The humanly readable string.
*/
void TaskSpec_print(TaskSpec *spec, UT_string *output);
std::string TaskSpec_print(TaskSpec *spec);

/**
* Create a copy of the task spec. Must be freed with TaskSpec_free after use.
Expand Down
2 changes: 0 additions & 2 deletions src/common/test/db_tests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
#include "state/redis.h"
#include "task.h"

#include "utstring.h"

SUITE(db_tests);

TaskBuilder *g_task_builder = NULL;
Expand Down
238 changes: 0 additions & 238 deletions src/common/thirdparty/utarray.h

This file was deleted.

Loading

0 comments on commit e0360eb

Please sign in to comment.