Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix uv runtime environment hook if sys.argv is changed by user script (…
…#50597) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This fixes an issue @erictang000 was running into while using the uv runtime env hook for https://github.com/hiyouga/LLaMA-Factory. LLaMA Factory modifies sys.argv before calling ray.init (and therefore the hook), which broke the original logic. We instead use the value from `/proc/{pid}/cmdline` and add a test that we can tolerate changes of sys.argv. ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(
- Loading branch information