-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FlowControl]Flowcontrol on empty messages #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…control Conflicts: streaming/src/channel/channel.cc streaming/src/test/mock_transfer_tests.cc
jovany-wang
reviewed
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I'm not very familiar with the logic. Just left some code style/detailed comments.
I'll take a deep look later. |
Co-authored-by: Qing Wang <kingchin1218@126.com>
…obius into empty-message-flow-control
jovany-wang
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jovany-wang
approved these changes
Feb 18, 2022
ashione
added a commit
that referenced
this pull request
Feb 21, 2022
* Flowcontrol on empty messages * mock queue empty message flow control * Update streaming/src/channel/channel.h Co-authored-by: Qing Wang <kingchin1218@126.com> * convert -1 to uint64_t max * timer interval init Co-authored-by: ashione <lingxuan.zlx@antgroup.com> Co-authored-by: Qing Wang <kingchin1218@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send less empty message when downstream receives messages from many upstreams, which will reduce cpu util at low bits inflight.