Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlowControl]Flowcontrol on empty messages #15

Merged
merged 8 commits into from
Feb 18, 2022

Conversation

ashione
Copy link
Member

@ashione ashione commented Jan 26, 2022

Send less empty message when downstream receives messages from many upstreams, which will reduce cpu util at low bits inflight.

@ashione ashione requested a review from BalaBalaYi January 26, 2022 03:48
ashione added 2 commits January 26, 2022 16:01
…control

Conflicts:
	streaming/src/channel/channel.cc
	streaming/src/test/mock_transfer_tests.cc
@ashione ashione requested a review from jovany-wang February 9, 2022 14:53
@ashione ashione changed the title [WIP][FlowControl]Flowcontrol on empty messages [FlowControl]Flowcontrol on empty messages Feb 10, 2022
Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I'm not very familiar with the logic. Just left some code style/detailed comments.

@jovany-wang
Copy link
Contributor

I'll take a deep look later.

Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovany-wang jovany-wang merged commit 92afce5 into master Feb 18, 2022
@jovany-wang jovany-wang deleted the empty-message-flow-control branch February 18, 2022 06:08
ashione added a commit that referenced this pull request Feb 21, 2022
* Flowcontrol on empty messages

* mock queue empty message flow control

* Update streaming/src/channel/channel.h

Co-authored-by: Qing Wang <kingchin1218@126.com>

* convert -1 to uint64_t max

* timer interval init

Co-authored-by: ashione <lingxuan.zlx@antgroup.com>
Co-authored-by: Qing Wang <kingchin1218@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants