Fix finalizer typo and re-create manifests

[AlessandroPomponio]

Why are these changes needed?

These changes address issue #630

When trying to create one of the example RayCluster on OpenShift, it will fail with the operator reporting "cannot set blockOwnerDeletion if an ownerReference refers to a resource you can’t set finalizers on:".

As per https://sdk.operatorframework.io/docs/faqs/#after-deploying-my-operator-why-do-i-see-errors-like-is-forbidden-cannot-set-blockownerdeletion-if-an-ownerreference-refers-to-a-resource-you-cant-set-finalizers-on-, we were able to fix the issue by applying the new role.yaml that is created running make manifests after applying the changes in this PR.

Related issue number

Closes #630

Checks

As mentioned, this PR was tested by applying the contents of the role.yaml file to the kuberay-operator ClusterRole

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[Jeffwan]

It is indeed a typo! Thanks for the fix! the change looks good to me

[AlessandroPomponio]

Just a quick double check @Jeffwan - I see the consistency check for the helm chart rbac is failing. Is that supposed to happen due to the changes?
Just to make sure everything is correct.

Thanks a lot in advance.
Alessandro

[kevin85421]

Just a quick double check @Jeffwan - I see the consistency check for the helm chart rbac is failing. Is that supposed to happen due to the changes? Just to make sure everything is correct.

Thanks a lot in advance. Alessandro

I will check the consistency check.

@AlessandroPomponio

RBAC YAML files in helm-chart/kuberay-operator/templates and ray-operator/config/rbac should be synchronized. Hence, you also need to update the RBAC files in helm-chart/kuberay-operator/templates. You can check: (1) DEVELOPMEND.md (2) GitHub Actions for more details.

[DmitriGekhtman]

RBAC files in the Helm charts need to be updated manually.
Specifically, the following file needs the same fix:
https://github.com/ray-project/kuberay/blob/master/helm-chart/kuberay-operator/templates/role.yaml

Once that's done, you can run python ../scripts/rbac-check.py from the root of KubeRay repo to verify that things are correctly synced.
We were unfortunately unable to automate this syncing process.

See https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#consistency-check

[DmitriGekhtman]

Match up Helm roles to get the helm rbac consistency check to pass.

[AlessandroPomponio]

Thank you both @kevin85421 and @DmitriGekhtman for being so kind and pointing me towards the right direction.

From the docs I had imagined something had to be done but I didn't understand they had to be synchronized manually, I assumed there was an automated process in place (and that I had missed some command). Maybe it could help new users if it was made more explicit in the docs 😃

[kevin85421]

Thank you both @kevin85421 and @DmitriGekhtman for being so kind and pointing me towards the right direction.

From the docs I had imagined something had to be done but I didn't understand they had to be synchronized manually, I assumed there was an automated process in place (and that I had missed some command). Maybe it could help new users if it was made more explicit in the docs 😃

Good idea! I will update the doc. Thank you for pointing this out!

[DmitriGekhtman]

Thank you both @kevin85421 and @DmitriGekhtman

...I failed to read the comment thread, sorry for the redundant info :)

[DmitriGekhtman]

Thank you!

This is not the first time we've burned ourselves with singular vs. plural in rbac...