Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][kubectl-plugin] Add dynamic shell completion for kubectl ray get node & workergroup #3154

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Mar 4, 2025

Why are these changes needed?

Add dynamic shell completion for kubectl ray get node and kubectl ray get workergroup.
This feature is only limited to the --ray-cluster flag.

Desktop.2025.03.04.-.23.30.55.03.mp4

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

…et node & workergroup

Signed-off-by: win5923 <ken89@kimo.com>
@win5923
Copy link
Contributor Author

win5923 commented Mar 4, 2025

@MortalHappiness PTAL thx.

@kevin85421
Copy link
Member

also cc @davidxia for review

@kevin85421 kevin85421 merged commit 4e3340c into ray-project:master Mar 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants