[Bug] Re-enable flaky kubectl plugin e2e test in kubectl_ray_job_submit_test.go #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenowenisme
force-pushed
the
re-enable-kubectl-plugin-ray-job-submit-test
branch
3 times, most recently
from
bcef3f7 to
a2256b1
Compare
Signed-off-by: You-Cheng <mses010108@gmail.com>
Signed-off-by: You-Cheng <mses010108@gmail.com>
Signed-off-by: You-Cheng <mses010108@gmail.com>
Signed-off-by: You-Cheng <mses010108@gmail.com>
owenowenisme
force-pushed
the
re-enable-kubectl-plugin-ray-job-submit-test
branch
from
372bf59 to
5b9ae41
Compare
Signed-off-by: You-Cheng <mses010108@gmail.com>
owenowenisme
force-pushed
the
re-enable-kubectl-plugin-ray-job-submit-test
branch
from
707f82b to
4108c51
Compare
Signed-off-by: You-Cheng <mses010108@gmail.com>
Signed-off-by: You-Cheng <mses010108@gmail.com>
|
@MortalHappiness |
.buildkite/setup-env.sh
Outdated
| apt-get install -y python3.11 python3-pip | ||
|
|
||
| # Install requirements | ||
| pip install --break-system-packages ray==2.41.0 ray\[default\]==2.41.0 |
There was a problem hiding this comment.
Suggested change
| pip install --break-system-packages ray==2.41.0 ray\[default\]==2.41.0 | |
| pip install --break-system-packages ray[default]==2.41.0 |
Comment on lines
+34
to
+35
| killKubectlCmd := exec.Command("pkill", "-9", "kubectl") | ||
| _ = killKubectlCmd.Run() |
There was a problem hiding this comment.
Why are these changes needed?
There are 2 reason make the test fail.
- There are some kubectl process occupied the 8265 port that is required by the kubectl job submit. But for the independence of tests, we should not expect the test cause this problem to kill the process properly every time, so added the pkill kubectl before running kubectl job submit test.
- The ray is not installed on build kite env, so modified the setup-env.sh to install.
There was a problem hiding this comment.
We should also example which tests occupy this port. This can be done in follow-up PRs. Once we find the test, we need to kill the kubectl process at the end of the test.
|
Could you also create another "[DO NOT MERGE]" draft PR and run it more than 5 times and make sure all tests pass? Just like what I did in #3116 (review) |
Signed-off-by: You-Cheng <mses010108@gmail.com>
|
https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds?branch=owenowenisme%3Apr%2F3124%2Fci-test |
Signed-off-by: You-Cheng <mses010108@gmail.com>
MortalHappiness
approved these changes
Feb 28, 2025
kevin85421
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There are 2 reason make the test fail.
Related issue number
Closes #2801
Checks