Java-Nerdery-ChallengeV2/Luis-Moroco #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nused structures and meaningless comments
…alues. Simplify winner verification in winningHand
…ns when count is 0
cmonterrosad
requested review from
quebin31,
sergiolg98,
cmonterrosad and
sbobadilla8
quebin31
reviewed
Nov 27, 2024
Comment on lines
+124
to
+126
| for (int j = 1; j <= i; ++j) { | ||
| ownPower = ownPower.multiply(BigInteger.valueOf(i)); | ||
| } |
There was a problem hiding this comment.
Use pow (or modPow if using modulo-based solution)
quebin31
reviewed
Nov 27, 2024
Comment on lines
+22
to
+23
| if (parser.nextToken() == JsonToken.START_ARRAY) { | ||
| while (parser.nextToken() != JsonToken.END_ARRAY) { |
There was a problem hiding this comment.
Why are we parsing the list like this?
|
Why are we using reflection? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mandatory challenges and the extra challenge were solved.
As for the extra challenge, you must download the .json file from the web and set the ExtraChallenges.FILE_PATH for it to run.